Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate 7 #1279

Merged
merged 13 commits into from
Mar 14, 2021
Merged

Release Candidate 7 #1279

merged 13 commits into from
Mar 14, 2021

Conversation

hoffmang9
Copy link
Member

@hoffmang9 hoffmang9 commented Mar 13, 2021 •
edited
Loading

Changed

  • Our green flag test blockchain launch worked but it uncovered a flaw in our installer versions. This release is a bug fix release to address that flaw. You should read the RC6 changes below if this is your first time installing since RC5.
  • chia netspace now defaults to 1000 blocks to mirror the GUI.
  • The installer build process was spruced up some.

Fixed

  • Setting difficulty way too low on the testnet_6 launch revealed a Timelord edge case. The full node was hardcoding the default difficulty if block height is < EPOCH_BLOCKS. However there were many overlapping blocks, so none of the blocks reached the height, and therefore the timelord infused the wrong difficulty.
  • Fixed a race condition in the Timelord, where it took time to update the state, so it ignored the new_peak_timelord form the full_node, which should have reset the timelord to a good state.
  • Wallet notoriously showed "not synced" when it was in sync.
  • Installers were not correctly placing root TLS certificates into the bundle.
  • Weight proofs had a logic typo.
  • There was a typo in chia netspace. Thanks @altendky.
  • There was a typo in chia plots. Thanks @AdamFiddler.

Known Issues

  • Some users can't plot in the GUI in MacOS Big Sur - especially on M1. See issue 1189

almogdepaz and others added 9 commits March 12, 2021 13:35
@almogdepaz
fix condition (#1260)
23a5cc0 
* fix condition
@Yostra
use raw (#1267)
abadc10
@hoffmang9
spec file changes (#1266)
67f5cd5 
* spec file changes

* Clean up installer build process

* revert as PR 1267 is right
@hoffmang9
netspace to GUI mirror defaults (#1268)
2e1c4b5
@hoffmang9
Chglg for RC7 (#1269)
2d0b5ef
@mariano54
Update sync status (#1272)
0be31f7
@mariano54
Timlord updates state immediately, prevents race condition (#1271)
de61385
@altendky
docstring hases -> hashes (#1270)
7534383
@hoffmang9
Various clean ups, spelling thanks @AdamFiddler, isort (#1278)
4697e39 
* Various clean ups, spelling thanks @AdamFiddler, isort

* Actually thank @AdamFiddler

* isort tests

* Update changelog, readme, spec, spelling

* Readme nit

* locales

* locales again
@lgtm-com
Copy link

lgtm-com bot commented Mar 13, 2021

This pull request introduces 1 alert and fixes 2 when merging 4697e39 into cf095a0 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Module is imported with 'import' and 'import from'

@hoffmang9 hoffmang9 changed the title Release Candidate 7 Release Candidate 6 Mar 13, 2021
@hoffmang9 hoffmang9 changed the title Release Candidate 6 Release Candidate 7 Mar 13, 2021
@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2021

This pull request introduces 1 alert and fixes 2 when merging 8084433 into cf095a0 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Module is imported with 'import' and 'import from'

wjblanke
wjblanke approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar enough with the epoch bug but the rest looks ok

@mariano54
Copy link
Contributor

The timelords stalled out when hitting the first epoch boundary

@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2021

This pull request introduces 1 alert and fixes 2 when merging 3972cc7 into cf095a0 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Module is imported with 'import' and 'import from'

@hoffmang9 hoffmang9 merged commit 3972cc7 into main Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hoffmang9 @mariano54 @wjblanke @almogdepaz @Yostra @altendky