-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIA-597: Use poetry
for package management
#11057
Conversation
|
@SocketSecurity ignore pypi/[email protected] |
|
when testing this on Mac (M1) I get this warning:
I suppose this is related to #18253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. It would be nice to have some documented guidance on how treat the lockfile, and PRs making changes to it. I assume it would be accepted with caution, as we want to lock down our supply-chain risk.
Waiting on coverage-diff override |
Sorry Clicked the wrong thing and ended up closing and reopening the PR |
Yes, generally you will want to use poetry to make any changes, eg:
However, I'm also hopeful that now all the dependencies are listed in the lock file, we can relay on |
Well, dependabot seems to have a flow in that it updates the So that might take some manual effort per the reporter until that gets resolved.... |
|
Pull Request Test Coverage Report for Build 9860288518Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
|
Devs should continue to use the
install.sh
/Install.ps1
scripts for convenience. These scripts do the following:Download and install
poetry
into.penv
Setup a chia-blockchain specific
.venv
Create a symlink between
venv
and.venv
You can then use activate in the same way as before
This approach keeps the poetry deployment in
.penv
separate from the chia-blockchain install in.venv
. If you want to run thepoetry
command you will need to run it from the.penv
directory.You can install
poetry
globally if you want, but then you may need to pay attention to the versioning in poetry specifically (running a different version from the one installed ininstall.sh
may have unexpected results). We are still exploring options on better ways to handle thepoetry
install.Draft for:
TODO
schiavdf
from source https://github.com/Chia-Network/chia-blockchain/runs/8059378328?check_suite_focus=true