Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX [NEW CADT UI] - Need asterisks next to required fields in create project/unit modals #1222

Closed
ccornick opened this issue May 8, 2024 · 3 comments
Closed

FIX [NEW CADT UI] - Need asterisks next to required fields in create project/unit modals #1222

ccornick opened this issue May 8, 2024 · 3 comments

Comments

@ccornick
Copy link
Contributor

ccornick commented May 8, 2024 •
edited
Loading

Required fields should be shown with an asterisk in create modals.

Image
wwills2 added a commit that referenced this issue May 10, 2024
@wwills2
Merge pull request #1233 from Chia-Network/refactor/fix/asterisks-on-…
81c8819 
…required-fields

Refactor/fix/asterisks on required fields : issue #1222
@ccornick
Copy link
Contributor Author

ccornick commented May 10, 2024 •
edited
Loading

Working well on most fields, but this field now requires a value, and it shouldn't.

Image

@ccornick
Copy link
Contributor Author

ccornick commented May 10, 2024 •
edited
Loading

Additionally Validation Date should not be a required field.

Image

@wwills2
Copy link
Collaborator

wwills2 commented May 13, 2024

the required validation and required markers should now match those of the old version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccornick @wwills2