Fix the Windows flow and improve the others #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffmang9
approved these changes
Jun 21, 2023
hoffmang9
added a commit
that referenced
this pull request
Jun 22, 2023
* Add back nightly testing of blst dependency * missing endif () * temporarily run on all pushes and PRs to test * yaml fixup * Fix origin/main tag issue * blst still uses master * windows fixes, less linux cmake * more windows tweaks * windows env fix, try runtest again * Fix the Windows flow and improve the others (#413) * Try setting the env at the workflow level * move to env: for all steps * Fix Linux build when using blst's main. Discovered by Earle. (#415) * Remove regular on PR for nightly and on-demand --------- Co-authored-by: Amine Khaldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs #412 which we'll get when it lands on main.