Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing destructor for CoreMPL and final for nested classes #371

Merged
merged 1 commit into from
May 9, 2023

Conversation

wallentx
Copy link
Contributor

@wallentx wallentx commented May 8, 2023

Signing commit from @knst from #359

Signing commit from @knst from #359

Co-Authored-By: Konstantin Akimov <[email protected]>
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arvidn also approved #359

@wallentx wallentx marked this pull request as ready for review May 8, 2023 19:34
@wallentx wallentx changed the title Update schemes.hpp fix: add missing destructor for CoreMPL and final for nested classes May 9, 2023
@wallentx wallentx merged commit 956d310 into main May 9, 2023
@wallentx wallentx deleted the wallentx/pr-359 branch May 9, 2023 23:54
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Jun 10, 2023
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants