Issue #27 - Add basic CRUD operation step definitions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balintpekker
changed the title
Add CRUD step definitions for block_content. Todo: blockContentCreate() method.
Sweetchuck
reviewed
Feb 15, 2021
| * | ||
| * @var array | ||
| */ | ||
| protected $blockContents = []; |
There was a problem hiding this comment.
\Cheppers\DrupalExtension\Context\Drupal\AppContentEntitySetupTearDown
There was a problem hiding this comment.
Removed in commit 6434a92.
| * @Given I am visiting the :type block content :info | ||
| * @Given I visit the :type block content :info | ||
| */ | ||
| public function iAmViewingTheBlockContent(string $type, string $info) |
There was a problem hiding this comment.
Naming convention of methods:
- Method which creates or do something (eg: click on a link) has to start with
do. - Method which checks something has to start with
assert.
See examples in the existing Context classes (./src/Context/Drupal/*)
- \Cheppers\DrupalExtension\Context\Drupal\CoreTabs::assertPrimaryTabsTable()
- \Cheppers\DrupalExtension\Context\Drupal\CoreTabs::doClickPrimaryTab()
There was a problem hiding this comment.
Fixed in commit 6434a92.
Remove after scenario methods and rename others to pass naming convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRUD step definitions for block_content.
Todo: blockContentCreate() method.
Closes #27