Extend the functionality of the folder module

[msekania]

Extends the functionality of the folder module.
See also #533 .

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: #533

What is the new behavior?

• One can supply a) a list o strings or b) dict as a romote_attributes parameter.
• a) reproduces the functionality of the REST API, and was already implemented
• b) removes the specified attribute if the given folder had such an attribute.

Other information

[lgetwan]

Thanks a lot for improving the functionality of this module! It looks like you invested quite a bit of Hirnschmalz. :-)
Unfortunately, the diff shown here is not the diff between feature/migrate_folder_module and feature/extend_folder_module_functionality, but agains the devel branch. So I did my own diff on the commandl ine. ;-)
I added some comments, but nothing severe.

[msekania]

Thanks a lot for improving the functionality of this module! It looks like you invested quite a bit of Hirnschmalz. :-) Unfortunately, the diff shown here is not the diff between feature/migrate_folder_module and feature/extend_folder_module_functionality, but agains the devel branch. So I did my own diff on the commandl ine. ;-) I added some comments, but nothing severe.

@lgetwan
I do not know what went wrong here, but header says

msekania wants to merge 10 commits into Checkmk:feature/migrate_folder_module from msekania:feature/extend_folder_module_functionality

and Resolve conflicts shows also something different than branch changes 🤷‍♂️

[lgetwan]

For some reason, the integration test that checks idempotency, fails in the 2nd step of these two:

- name: "{{ outer_item.version }} - {{ outer_item.edition | upper }} - Update folder attributes without specifying title (name)."
  folder:
    server_url: "{{ checkmk_var_server_url }}"
    site: "{{ outer_item.site }}"
    automation_user: "{{ checkmk_var_automation_user }}"
    automation_secret: "{{ checkmk_var_automation_secret }}"
    path: "{{ checkmk_folder_attr_test.path }}"
    state: "present"
    update_attributes:
      tag_criticality: "test"
      tag_networking: "wan"
  delegate_to: localhost
  run_once: true  # noqa run-once[task]

- name: "{{ outer_item.version }} - {{ outer_item.edition | upper }} - Check the idempotency of Update attributes."
  folder:
    server_url: "{{ checkmk_var_server_url }}"
    site: "{{ outer_item.site }}"
    automation_user: "{{ checkmk_var_automation_user }}"
    automation_secret: "{{ checkmk_var_automation_secret }}"
    path: "{{ checkmk_folder_attr_test.path }}"
    update_attributes:
      tag_criticality: "test"
    state: "present"
  delegate_to: localhost
  run_once: true  # noqa run-once[task]
  register: test_output
  failed_when: test_output.changed | bool

The forst task returns:

"msg": "200 - Folder modified. Changed: update attributes: {\"tag_criticality\": \"test\", \"tag_networking\": \"wan\"}"

The second one returns:

 "msg": "200 - Folder modified. Changed: attributes"

[msekania]

might be related to the fact that attribute is {}.

I have to check it.

[msekania]

For some reason, the integration test that checks idempotency, fails in the 2nd step of these two:

I found the issues, line 307,
In essence I have introduced it when I "simplified" if statement.
Sorry

[lgetwan]

Thanks for fixing this, Michael!
Then, the PR is ready to be merged. :-)