Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(queries): add missing check in ec2 instance has public ip #5720

Merged
merged 12 commits into from
Aug 23, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Aug 19, 2022

Closes #5643

Proposed Changes

  • add missing check in "ec2 instance has public IP" Security Query
  • rename CF security query
  • fix go sec

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature terraform Terraform query ansible Ansible query aws PR related with AWS Cloud labels Aug 19, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Aug 19, 2022
rafaela-soares
rafaela-soares previously approved these changes Aug 22, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
e2e/utils/helper.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
.github/scripts/report/e2e-html.go Fixed Show fixed Hide fixed
rafaela-soares
rafaela-soares previously approved these changes Aug 22, 2022
@rafaela-soares rafaela-soares merged commit 0d3461a into master Aug 23, 2022
@rafaela-soares rafaela-soares deleted the fix/ec2_instance_has_public_ip branch August 23, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible query aws PR related with AWS Cloud bug Something isn't working query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: terraform ec2_instance_has_public_ip
2 participants