Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyExpectedValue): cloudformation-aws queries convert to a recomm… #5646

Conversation

liorj-orca
Copy link
Contributor

…endation rather than a current status

Closes #

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the community Community contribution label Jul 28, 2022
@rafaela-soares
Copy link
Contributor

rafaela-soares commented Jul 28, 2022

Hello, @liorj-orca!

Thank you so much for continuing to improve KICS queries 🚀

The PR failed in E2E tests. Do you need any help with that? As a tip, you can see E2E documentation to know how to run E2E tests.

Also, you can access the HTML E2E report in the summary of the GitHub action.

Except for it, LGTM 🚀

@gabriel-cx
Copy link
Contributor

Hello, @liorj-orca!
Feel free to ping me if you need something from our side in order to close this PR! ⛵
If you prefer, we can close it in our side.

@rafaela-soares rafaela-soares added the query New query feature label Aug 19, 2022
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares merged commit 1608f18 into Checkmarx:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants