feat(common lib): improved performance of get_nested_values_info #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan submitted to Checkmarx |
|
Cx-SAST SummaryTotal of 5 vulnerabilities Violation SummaryNo policy violation found |
rafaela-soares
previously approved these changes
Mar 29, 2022
|
@Churro, can you please resolve the conflicts with the master? Thank you so much in advance 😊 |
|
Done, @rafaela-soares 👍 |
rafaela-soares
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4955 introduced a novel approach to check objects for nested attributes. As tested in #4884, the recursive expansion of
pathvalues is done for all attributes within the tested object, even though the check would only be needed for a set of attributes that are already known beforehand. This impacts runtime complexity, especially with deeper nested hierarchies.Proposed Changes
get_nested_values_infoandremove_last_point. Input and output remain unchanged. For the sample in fix(query): Extend net_raw_capabilities_not_being_dropped k8s rule to cover further resource kinds #4884, this roughly halvestimer_rego_query_eval_ns- on my PC, from 1.18ms to 0.54msI submit this contribution under the Apache-2.0 license.