Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Extend container_requests_not_equal_to_its_limits k8s rule to cover further resource kinds and remove redundant checks #4974

Conversation

Churro
Copy link
Contributor

@Churro Churro commented Mar 13, 2022

Proposed Changes

  • Extend the rule to cover additional resource kinds, e.g., Deployment, DaemonSet, etc.
  • Remove redundant MissingAttribute checks that are covered by other rules. While this rule has a LOW severity rating, checks for missing cpu and memory attributes are rated MEDIUM.

I submit this contribution under the Apache-2.0 license.

…e to cover further resource kinds and remove redundant checks
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you so much for another contribution!

@joaoReigota1 joaoReigota1 merged commit 8bd629f into Checkmarx:master Mar 14, 2022
@kaplanlior kaplanlior added the community Community contribution label Mar 14, 2022
@rafaela-soares rafaela-soares added the query New query feature label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants