fix(query): k8s rule service_account_token_automount_not_disabled should also consider automount option in ServiceAccount #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld also consider automount option in ServiceAccount
|
Scan submitted to Checkmarx |
joaoReigota1
requested changes
Mar 9, 2022
There was a problem hiding this comment.
Hi @Churro, thank you for contributing to KICS and helping us improve our Kubernetes queries.
Indeed you are correct, other than a change that is required for our k8s files validator, everything seems good to me and I will be happy to merge it
assets/queries/k8s/service_account_token_automount_not_disabled/test/negative2.yaml
Show resolved
Hide resolved
|
Scan not submitted to Checkmarx due to existing Active scan for the same project. |
|
Cx-SAST SummaryTotal of 5 vulnerabilities Violation SummaryNo policy violation found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
automountServiceAccountTokencan also be defined at Service Account level. Pods may override this setting. The current rule inspectsautomountServiceAccountTokenonly on pod level and yields false positive alerts in case this setting is defined together with the Service Account.Proposed Changes
specInfowith SA definition and check whether the SA definesautomountServiceAccountTokenI submit this contribution under the Apache-2.0 license.