Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to import a SARIF file (AST-36884, AST-36890) #674

Merged
merged 164 commits into from
May 7, 2024
Merged

Add the ability to import a SARIF file (AST-36884, AST-36890) #674

merged 164 commits into from
May 7, 2024

Conversation

checkmarx-kobi-hagmi
Copy link
Contributor

@checkmarx-kobi-hagmi checkmarx-kobi-hagmi commented Mar 10, 2024 •
edited by OrShamirCM
Loading

Description

Added the ability to import a SARIF file via Import command.

References

https://checkmarx.atlassian.net/browse/AST-36884
https://checkmarx.atlassian.net/browse/AST-36890

Testing

  • Added unit and integration tests for the import command with different files.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested review from a team, diogopcx and tiagobcx and removed request for a team March 10, 2024 14:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – e51d1838-afcd-4677-ae18-555198be9d95

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

OrShamirCM
OrShamirCM reviewed Mar 10, 2024
View reviewed changes
internal/commands/import.go Outdated Show resolved Hide resolved
internal/commands/import.go Outdated Show resolved Hide resolved
internal/commands/import.go Outdated Show resolved Hide resolved
internal/commands/import.go Outdated Show resolved Hide resolved
internal/commands/import_test.go Outdated Show resolved Hide resolved
internal/commands/scan_test.go Outdated Show resolved Hide resolved
internal/commands/scan.go Outdated Show resolved Hide resolved
@checkmarx-kobi-hagmi checkmarx-kobi-hagmi changed the base branch from feature/import-sarif-file to main March 12, 2024 13:19
@checkmarx-kobi-hagmi checkmarx-kobi-hagmi changed the base branch from main to feature/import-sarif-file March 12, 2024 13:22
@OrShamirCM OrShamirCM self-requested a review May 7, 2024 11:36
@OrShamirCM OrShamirCM merged commit 7342007 into main May 7, 2024
8 checks passed
@OrShamirCM OrShamirCM deleted the feature/kobih/import-sarif-file branch May 7, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamarleviCm tamarleviCm tamarleviCm approved these changes

@OrShamirCM OrShamirCM OrShamirCM approved these changes

@tiagobcx tiagobcx tiagobcx approved these changes

@diogopcx diogopcx Awaiting requested review from diogopcx diogopcx was automatically assigned from Checkmarx/ast-galactica-team

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@checkmarx-kobi-hagmi @OrShamirCM @tiagobcx @tamarleviCm