Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix small bugs #618

Merged
merged 10 commits into from
Nov 24, 2023
Merged

fix small bugs #618

merged 10 commits into from
Nov 24, 2023

Conversation

pedrompflopes
Copy link
Collaborator

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested review from a team, diogopcx and igorlombacx and removed request for a team November 20, 2023 09:56
@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 14b2fb7a-d8aa-4dbb-b042-28208f1c5129

No New Or Fixed Issues Found

igorlombacx
igorlombacx approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@igorlombacx igorlombacx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tiagobcx
tiagobcx approved these changes Nov 24, 2023
View reviewed changes
internal/commands/result.go Show resolved Hide resolved
@pedrompflopes pedrompflopes merged commit 582f2f6 into main Nov 24, 2023
8 checks passed
@pedrompflopes pedrompflopes deleted the bug/gl_report_and_apisecurity branch November 24, 2023 17:00
tiagobcx pushed a commit that referenced this pull request Jan 22, 2024
@pedrompflopes
fix small bugs (#618)
bec72e0 
* fix small bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorlombacx igorlombacx igorlombacx approved these changes

@tiagobcx tiagobcx tiagobcx approved these changes

@diogopcx diogopcx Awaiting requested review from diogopcx diogopcx was automatically assigned from Checkmarx/ast-galactica-team

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedrompflopes @tiagobcx @igorlombacx