Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CLI always create a folder with the name 'project-name' and not a given project name #607

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

igorlombacx
Copy link
Contributor

@igorlombacx igorlombacx commented Oct 27, 2023

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Examples:

After running a scan using --sca-resolver flag and --sca-resolver-params "--log-level=Verbose"
A log is created and inside a log folder, we can find a folder that should be defined by the project name flag value.

before fixing, inside the log folder, the folder was always created and named "project-name":
image

after fix:
image

References

https://checkmarx.atlassian.net/browse/AST-31127?atlOrigin=eyJpIjoiZmZmM2JhOGFmNDM0NGI1N2IzOWY3MTMwYWE4YWRkNjMiLCJwIjoiaiJ9

Testing

manual tests

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested review from a team, sshay77 and pedrompflopes and removed request for a team October 27, 2023 08:15
@github-actions github-actions bot added the bug Something isn't working label Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Logo
Checkmarx One – Scan Summary & Detailsb236f4f5-c1ac-415b-a636-62f267e2c165

No New Or Fixed Issues Found

@igorlombacx igorlombacx marked this pull request as ready for review October 27, 2023 14:50
@pedrompflopes pedrompflopes requested a review from a team October 27, 2023 14:50
@igorlombacx igorlombacx changed the title Fix for CLI always create a folder with name 'project-name' and not a given project name Fix for CLI always create a folder with the name 'project-name' and not a given project name Oct 27, 2023
@tiagobcx tiagobcx merged commit 3a1e0e2 into main Nov 14, 2023
9 checks passed
@tiagobcx tiagobcx deleted the BUG/AST-31127-PROJECT-NAME-FIX branch November 14, 2023 09:35
tiagobcx pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants