-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validity check #206
Conversation
looks good to me, I think its worth adding an optional permission scopes of the found active secrets. regarding terminology, suggesting to use |
As defined in #191, the possible values of the validation field are Since it is not guaranteed the user will enable this feature. the field might be empty, and I want its name to be meaningful and the user will understand why it is empty. I left with the |
After adding the simple validation process on #206, I'm now adding a validation process for cases where both _access key_ and _secret key_ are needed together. For these cases, the engine will collect those secrets and after the scan is finished, it will validate all the pairs.
This PR is the first implementation of validity check #191.
I added the flow of validation, controlled by the
--validate
flag, and added validation for Github token.