fix: unique ID for secrets #125
Conversation
BREAKING CHANGES: finding ID was changed
|
KICS version: v1.7.0
|
secrets/secrets.go
Outdated
| secretsChannel <- reporting.Secret{ | ||
| ID: itemId, | ||
| Description: item.Description, | ||
| Type: value.Description, | ||
| StartLine: value.StartLine, | ||
| StartColumn: value.StartColumn, | ||
| EndLine: value.EndLine, | ||
| EndColumn: value.EndColumn, | ||
| Value: value.Secret, | ||
| } |
There was a problem hiding this comment.
Source: item.ID changed to Source: item.Source
Description: value.Description changed to RuleID: value.RuleID
secrets/secrets.go
Outdated
| func getFindingId(item plugins.Item, finding report.Finding) string { | ||
| idParts := []string{item.ID, finding.RuleID, finding.Secret} | ||
| sha := sha256.Sum256([]byte(strings.Join(idParts, ""))) | ||
| return fmt.Sprintf("%x", sha) | ||
| } |
There was a problem hiding this comment.
Added finding.RuleID and finding.Secret to the result ID.
| const flagIgnored = "ignore" | ||
| const ( | ||
| flagFolder = "path" | ||
| flagProjectName = "project-name" |
There was a problem hiding this comment.
Added the --project-name to give the user the option to declare which project we're scanning.
It is needed because we can't get it without the user, maybe the folder is in a CI system and its location is always changing.
On the other hand, we need this option in case the user scans two folders with the same file inside.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return itemId | ||
| func getFindingId(item plugins.Item, finding report.Finding) string { | ||
| idParts := []string{item.ID, finding.RuleID, finding.Secret} | ||
| sha := sha1.Sum([]byte(strings.Join(idParts, "-"))) |
Check failure
Code scanning / gosec
Use of weak cryptographic primitive
There was a problem hiding this comment.
false positive, since not cryptographic use case
| @@ -1,9 +1,9 @@ | |||
| package secrets | |||
|
|
|||
| import ( | |||
| "crypto/sha1" | |||
Check failure
Code scanning / gosec
Blocklisted import crypto/sha1: weak cryptographic primitive
baruchiro
changed the title
BREAKING CHANGES:
IDDescriptionchanged toRuleIDAdded:
--project-nametogitplugin--project-nametofilesystempluginClose #124
Close #109 by implementing #109 (comment)