Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Filter Documentation With Type Rules, Improved Examples #298

Merged
merged 3 commits into from
Apr 9, 2023

Conversation

dnsge
Copy link
Contributor

@dnsge dnsge commented Apr 8, 2023

  • Adds a "Writing your own filters" section
  • Explains terminology
  • Explains typing rules and how they affect evaluation

Looking for criticism and suggestions about what I've updated and what already exists. I've never really been happy with the filters documentation but I don't really know what to change to make the documentation more useful to users and especially those with minimal programming experience (if possible).

To be merged with Chatterino/chatterino2#4364.

* Adds a "Writing your own filters" section
* Explains terminology
* Explains typing rules and how they affect evaluation
@netlify
Copy link

netlify bot commented Apr 8, 2023

Deploy Preview for chatterino-wiki-dev ready!

Name Link
🔨 Latest commit 08c066a
🔍 Latest deploy log https://app.netlify.com/sites/chatterino-wiki-dev/deploys/6432961846bf460008cca851
😎 Deploy Preview https://deploy-preview-298--chatterino-wiki-dev.netlify.app/filters
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I rewrote some stuff to flow better, but happy to hear your opinion before I merge this in

@dnsge
Copy link
Contributor Author

dnsge commented Apr 9, 2023

Looks good, thanks for making the language more casual and understandable.

@pajlada pajlada merged commit 4dcb772 into Chatterino:master Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants