refactor: deduplicate IRC parsing #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
commented
Oct 26, 2024
pajlada
reviewed
Oct 26, 2024
pajlada
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deduplicates the code for parsing historical vs. live messages. It introduces a
MessageSinkwhich hold some traits (some behavior as to how messages should be added). It is modelled after theChannel, which is why it has theaddMessagesignature. Ideally, I'd want to make a new function that just takes a message, but I couldn't come up with a good name (because ultimately, it will add a message to the sink). An alternative could be to makeMessageSinka wrapper aroundChannel.This should make it easier to parse specific messages (e.g. subs) without introducing differences between recent and live messages.