-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: some Application & style things #5561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application to the respective emote class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
…dates This means moving Settings loading up a bit in the initialization chain
PubSubManager/TwitchIrcServer
pajlada
force-pushed
the
chore/random-refactor-xd
branch
from
August 25, 2024 12:30
de69081
to
e1ea30e
Compare
pajlada
changed the title
chore: some small random refactors
refactor: some Application & style things
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Updates
class is now responsible for connecting toSettings
in its constructor. PreviouslyApplication
did this for it.The
initialized
state forApplication
has been moved to theApplication
class itself, and is no longer atomic.The
PubSub
initialization is now handled byPubSub
rather thanApplication
Global emote reloading on setting toggle is now handled by the respective emote class (e.g.
BttvEmotes
)Settings is now initialized slightly earlier to ensure Updates has access to it in its constructor. This shouldn't change anything, but who knows :)
Removed a use of
PubSub
's setAccount from TwitchChannel. This was extraneous since it's already handled by PubSubManager(previously Application)stylistic/clang-tidy fixes:
We use the static method of QApplication things where applicable (e.g.
QApplication::exec
instead ofqtApp.exec
inApplication
)Some static variables were uppercased in
ChatterSet
/BttvEmotes
Some includes were added/removed
Flattened some anon namespaces (i.e. moved them out of the chatterino namespace)