Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some Application & style things #5561

Merged
merged 20 commits into from
Aug 25, 2024
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Aug 25, 2024

The Updates class is now responsible for connecting to Settings in its constructor. Previously Application did this for it.

The initialized state for Application has been moved to the Application class itself, and is no longer atomic.

The PubSub initialization is now handled by PubSub rather than Application

Global emote reloading on setting toggle is now handled by the respective emote class (e.g. BttvEmotes)

Settings is now initialized slightly earlier to ensure Updates has access to it in its constructor. This shouldn't change anything, but who knows :)

Removed a use of PubSub's setAccount from TwitchChannel. This was extraneous since it's already handled by PubSubManager(previously Application)

stylistic/clang-tidy fixes:
We use the static method of QApplication things where applicable (e.g. QApplication::exec instead of qtApp.exec in Application)

Some static variables were uppercased in ChatterSet/BttvEmotes

Some includes were added/removed

Flattened some anon namespaces (i.e. moved them out of the chatterino namespace)

@pajlada pajlada marked this pull request as draft August 25, 2024 11:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/bttv/BttvEmotes.cpp Outdated Show resolved Hide resolved
src/providers/bttv/BttvEmotes.cpp Outdated Show resolved Hide resolved
@pajlada pajlada force-pushed the chore/random-refactor-xd branch from de69081 to e1ea30e Compare August 25, 2024 12:30
@pajlada pajlada changed the title chore: some small random refactors refactor: some Application & style things Aug 25, 2024
@pajlada pajlada marked this pull request as ready for review August 25, 2024 12:44
@pajlada pajlada merged commit 627c735 into master Aug 25, 2024
16 of 17 checks passed
@pajlada pajlada deleted the chore/random-refactor-xd branch August 25, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant