-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up QtCreator's package manager setup #5305
Conversation
9a1281f
to
bcef9df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributors using Qt Creator should pick just one (or none) to use and disable the other one, just now by default all are disabled.
In my opinion, if you have installed Qt Creator, you should be using conan, because it doesn't bring in Qt but uses the version installed on the system. vcpkg will compile qt from source, which can take some time (and might conflict with some assumptions Qt Creator makes (?)). Furthermore, only conan is tested in CI (#4099).
Conan might not have this "issue" but I did not test it out, since even the build of openssl or boost was taking well over 15 minutes already.
Conan doesn't build boost anymore. Only OpenSSL is built from source (this takes some time on Windows because they refuse to support any other build tool than nmake).
Since we support both package managers, I think it's a good idea to include a QtCreatorPackageManager.cmake
(compared to adding it to .gitignore
). However, only conan should be enabled. If a user doesn't want to have the auto-setup, they can turn it off in the Qt Creator settings.
This PR should also include documentation changes (at least) in BUILDING_ON_WINDOWS.md
.
Conan now autoexecutes and downloads or builds the libraries (it builds zlib and openssl for me) But when trying to run chatterino from qt creator, I get these errors The folder If I copy the files from (PS: this folder I'm not sure if this is a problem with the conanfile, or the cmakelists file. |
I do have that checked. I can't launch the app inside Qt creator, nor outside it. Unchecking this setting did not change anything for me. Maybe your build library search path (unsure what this variable is supposed to be) somehow has these openssl libraries? Checking and unchecking this setting only seems to add C:\Qt\6.7.1\msvc2019_64\bin into the Path variable (in the environment section), though I already have this in my path variable (i.e. it's already in the Path variable shown value). So if you get the same errors for the same libraries missing, I'm not sure whats going on, my only guess would be you already have openssl libraries in path, but in that case you would be getting missing qt libraries instead of libcrypto and libssl, is my guess. If you get the same libcrypto and libssl errors, then I'm not sure what or where is the problem. |
Added a QtCreatorPackageManager.cmake that gets auto imported when using Qt>6 with CMake and "Package manager auto setup" option (by default) turned on.
In this file, options to skip the automatic packagae manager setup is set up.
Options to skip exclusively conan, or vcpkg, are also set to on for self-documentation for the user.
Contributors using Qt Creator should pick just one (or none) to use and disable the other one, just now by default all are disabled.
A general status message with information about this gets sent right at the start of cmake command (as the QtCreatorPackageManager.cmake is one of the earliest things Qt Creator runs).
https://www.qt.io/blog/qt-creator-cmake-package-manager-auto-setup
[Extra Notes]
Vcpkg seems like it's not configured well to use with Qt Creator - since it downloads qt (and/or builds it).
Conan might not have this "issue" but I did not test it out, since even the build of openssl or boost was taking well over 15 minutes already.