Add highlight color and show in mentions to automod messages

[KleberPF]

For now, the added/removed term messages don't show up in /mentions, but I'll add a commit doing that if we decide to do it.

Previous messages change color when the user changes settings

Scrollbar color

Scrollbar color also changes when settings are changed

Message showing up in mentions

Message doesn't show up in mentions if setting is disabled

I was hitting an assert when allowing/denying a message, but I tested in master and it also happens there. It seems to be caused by the request created in Helix::manageAutoModMessages not being concurrent, but I didn't look too much into it. This was the call stack when the assert triggered

Fixes: #5206

[Nerixyz]

You didn't cause the assertion issue: isInStreamerMode is called in a PubSub handler:

chatterino2/src/Application.cpp

Line 710 in ea19c5c

isInStreamerMode())

The PubSub handler is running in it's own thread - not the GUI thread. isInStreamerMode isn't annotated, but has to run on a single thread as it accesses cache. This thread must be the GUI thread as it emits streamerModeChanged.

[KleberPF]

Oh, nice. I think I mixed some things up. I put a breakpoint in isGuiThread for when the result was false, but this function isn't called just inside assertInGuiThread, and it ends up begin called by some functions in NetworkData. Ended up posting the correct call stack

[pajlada]

I think the "header", i.e. message that contains the Allow & Deny buttons, should be colored based on the AutomodHighlight

[KleberPF]

I think the "header", i.e. message that contains the Allow & Deny buttons, should be colored based on the AutomodHighlight

Is it ok to set MessageFlag::AutoModOffendingMessage for that message or should I make a new flag?

[Nerixyz]

Is it ok to set MessageFlag::AutoModOffendingMessage for that message or should I make a new flag?

The issue with reusing the flag is that you'd create two highlights. You can avoid creating a new flag by checking for MessageFlag::Timeout, which is only set for offending messages, and the "header" in combination with AutoMod.

[KleberPF]

The issue with reusing the flag is that you'd create two highlights. You can avoid creating a new flag by checking for MessageFlag::Timeout, which is only set for offending messages, and the "header" in combination with AutoMod.

Something like this?

if (ctx.preferences.enableAutomodHighlight && 
    (this->message_->flags.has(MessageFlag::AutoModOffendingMessage) || 
     this->message_->flags.has(MessageFlag::Timeout))

checking for MessageFlag::Timeout, which is only set for offending messages

Is it a good idea to rely on this? I feel like it could break something in the future (I guess it's unlikely because we would need the same combination of flags)

[Nerixyz]

Is it a good idea to rely on this? I feel like it could break something in the future (I guess it's unlikely because we would the same combination of flags)

Yea, it's probably better to have a new flag.

[KleberPF]

Added coloring for the message header

in mentions

[Mm2PL]

Is it intended that AutoMod's "Hey! Your message is being checked" is not customizable with your changes? Those messages only have the PubSub flag set.
https://github.com/Chatterino/chatterino2/blob/master/src/providers/twitch/TwitchMessageBuilder.cpp#L4964

[KleberPF]

Is it intended that AutoMod's "Hey! Your message is being checked" is not customizable with your changes?

Good question. I interpreted the issue as "highlight that automod caught someone else's message", not "highlight that automod caught your message", but I'm not sure about the original intent.

[Mm2PL]

They look really similar right now on master and are from the same source. I am of the opinion that they should be thrown into the same bag as mod-side automod messages. I don't think the issue author even considered their existence. Interestingly enough currently these messages don't show up in /automod.

[pajlada]

I interpreted this as a moderator/broadcaster tool, so that's what I think is important

[pajlada]

Thank you @KleberPF !
Please don't forget to make a separate PR adding yourself into the About page :)