Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same input padding between light & dark themes #5095

Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jan 16, 2024

For context, before this change there was a difference in the margin of a split input depending on if your theme was dark or light.
This PR makes the margin the same regardless of theme.

Dark mode:
dark-mode

Light mode before this PR:
light-mode-before

Light mode with this PR:
light-mode-after

Thoughts @treuks ?

@treuks
Copy link
Contributor

treuks commented Jan 17, 2024

i cant really see what you mean by the margin being the same, there's a pretty huge difference

image psd(3)
image psd(4)

@pajlada
Copy link
Member Author

pajlada commented Jan 17, 2024

there's probably some other margin then being theme-specific then, the margin/padding/spacing this fixes is "inside" the text input (especially noticeable if you focus on the emote button)

@pajlada pajlada changed the title Use the same margin for the input for dark & light mode Use the same input padding between light & dark themes Jan 17, 2024
@pajlada pajlada enabled auto-merge (squash) January 17, 2024 20:16
@pajlada pajlada merged commit 7d5967c into master Jan 17, 2024
20 checks passed
@pajlada pajlada deleted the fix/normalize-input-margin-between-light-and-dark-mode branch January 17, 2024 20:34
devJimmyboy pushed a commit to devJimmyboy/chatterino7 that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants