Use the same input padding between light & dark themes #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i cant really see what you mean by the margin being the same, there's a pretty huge difference
|
|
there's probably some other margin then being theme-specific then, the margin/padding/spacing this fixes is "inside" the text input (especially noticeable if you focus on the emote button) |
…-margin-between-light-and-dark-mode
pajlada
changed the title
pajlada
deleted the
fix/normalize-input-margin-between-light-and-dark-mode
branch
1 task
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, before this change there was a difference in the margin of a split input depending on if your theme was dark or light.
This PR makes the margin the same regardless of theme.
Dark mode:
Light mode before this PR:
Light mode with this PR:
Thoughts @treuks ?