fix: non-native drag on Windows #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Dec 29, 2023
Nerixyz
force-pushed
the
fix/draggable-stuff
branch
from
9e0dd8c
to
ced5d2d
Compare
pajlada
approved these changes
Dec 29, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the parent to a
Spliton the usercards and reply threads caused the mouse-tracking code inBaseWindowto check theSplitandSplitContainer(both have mouse tracking).Fixes #5050.
I noticed the reply thread popup having a similar bug in the header where the checkbox has mouse tracking but doesn't handle events if it's stretched, so I inserted a dummy widget that takes the remaining space.