Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check for tall messages #5045

Merged
merged 2 commits into from
Dec 27, 2023
Merged

fix: Add check for tall messages #5045

merged 2 commits into from
Dec 27, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Dec 27, 2023

Previously, only the bottom and the top were checked. This PR adds a check for tall messages (taller than the channel-view).

Fixes #5044.

pajlada
pajlada approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it fixed the issue I reported - thank you for the quick turnaround!

@pajlada pajlada merged commit d0d2401 into Chatterino:master Dec 27, 2023
20 checks passed
@Nerixyz Nerixyz deleted the fix/region-paint branch December 27, 2023 15:50
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messages sometimes don't render, or flicker, if they are only partially visible with an animated emote
2 participants
@Nerixyz @pajlada