Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip parenting on Windows #5040

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Dec 25, 2023

This PR sets the parent on tooltips to be nullptr on Windows and deletes the tooltip when appropriate.

Fixes #5019.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a question about the documentation before I'll merge this in

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending small change from discussion above

@pajlada pajlada enabled auto-merge (squash) December 25, 2023 17:02
@pajlada pajlada merged commit 485fc5c into Chatterino:master Dec 25, 2023
20 checks passed
@Nerixyz Nerixyz deleted the fix/tooltip-parenting branch December 25, 2023 17:34
@pajlada pajlada mentioned this pull request Dec 29, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving over different windows' popups automatically switches focus
2 participants