Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanly exit Chatterino instead of force exiting #4993

Closed
wants to merge 14 commits into from
Closed

Cleanly exit Chatterino instead of force exiting #4993

wants to merge 14 commits into from

Commits on Dec 1, 2023

  1. Get rid of the pesky _exit call

    @Mm2PL
    Mm2PL committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    865dd13 View commit details
    Browse the repository at this point in the history

  2. changelog

    @Mm2PL
    Mm2PL committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    2dcd6be View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Don't use jthread because we can't

    @Mm2PL
    Mm2PL committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    76acef0 View commit details
    Browse the repository at this point in the history

  2. Update src/RunGui.cpp 

    Co-authored-by: pajlada <[email protected]>
    @Mm2PL @pajlada
    Mm2PL and pajlada authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    4e37e83 View commit details
    Browse the repository at this point in the history

  3. Update src/RunGui.cpp

    @Mm2PL
    Mm2PL authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    bf9fde6 View commit details
    Browse the repository at this point in the history

  4. Call stop() when destroying BasicPubSubManager

    @Mm2PL
    Mm2PL committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    51e5b66 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Destroy the window manager before TwitchIrcServer 

    TwitchIrcServer contains the channels, and they now live longer than the
windows themselves.

I made it so the dtor of WindowManager *actually* deletes the windows
now - i.e. them and everything in them are destroyed.
    @pajlada
    pajlada committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    fbf13c7 View commit details
    Browse the repository at this point in the history

  2. Add a parent to SplitInput's QCompleter 

    mini memory leak fix
    @pajlada
    pajlada committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    295b38a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/stop_windows_code_from_abort()ing_our_… 

    …process
    @pajlada
    pajlada authored Dec 3, 2023
    Configuration menu
    Copy the full SHA
    ca97fa4 View commit details
    Browse the repository at this point in the history

  4. Stop the 7tv heartbeat timer on shutdown request

    @pajlada
    pajlada committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    934e518 View commit details
    Browse the repository at this point in the history

  5. Rename the BasicPubSubManager thread

    @pajlada
    pajlada committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    06cb7d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. Merge branch 'master' into fix/stop_windows_code_from_abort()ing_our_… 

    …process
    @pajlada
    pajlada authored Dec 31, 2023
    Configuration menu
    Copy the full SHA
    48ca328 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Merge remote-tracking branch 'origin/master' into fix/stop_windows_co… 

    …de_from_abort()ing_our_process
    @pajlada
    pajlada committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    60a913e View commit details
    Browse the repository at this point in the history

  2. Remove now-unneccessary fakeDtor

    @pajlada
    pajlada committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    b62d257 View commit details
    Browse the repository at this point in the history