Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deadlock and use-after-free in tests #4981

Merged
merged 4 commits into from
Nov 26, 2023
Merged

fix: deadlock and use-after-free in tests #4981

merged 4 commits into from
Nov 26, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 26, 2023

Description

  • Fixes use-after-free in Settings (when custom settings get destroyed, getSettings() would still point to the old instance).
  • Fixes a deadlock (or similar?) as loading twitch accounts would init a request to 7TV.

pajlada
pajlada approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes, thank you! 👍 🚀 🔥

@pajlada pajlada enabled auto-merge (squash) November 26, 2023 15:36
@pajlada pajlada merged commit e8673fc into Chatterino:master Nov 26, 2023
19 checks passed
@Nerixyz Nerixyz deleted the fix/tests branch November 26, 2023 16:07
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada