Minor: AutoMod term management messages are now hidden in Streamer Mode. #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
changed the title
Felanbird
reviewed
Aug 7, 2023
| false, "Hide bans & timeouts from appearing in chat."); | ||
| layout.addCheckbox( | ||
| "Hide moderation actions", s.streamerModeHideModActions, false, | ||
| "Hide bans, timeouts and automod messages from appearing in chat."); |
There was a problem hiding this comment.
This is not technically a good description of what this PR did, BUT this setting already did hide automod messages so now the tooltip is more correct than it was before, and automod messages I believe is blanket enough to cover what we changed here.
There was a problem hiding this comment.
Suggested change
| "Hide bans, timeouts and automod messages from appearing in chat."); | |
| "Hide bans, timeouts, and automod messages from appearing in chat."); |
actually oxford would be mad at us if we didn't
pajlada
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
The change itself isn't major, but it may be a very visible change for streamers so I've elaborated on the changelog entry and moved it to be a Major change.
Alternatively, it could be a Minor change but left at the top instead.
I'm happy to have this merged in whenever someone else confirms my change
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
) Co-authored-by: Rasmus Karlsson <[email protected]>
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
) Co-authored-by: Rasmus Karlsson <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you add or remove a blocked term, it no longer gets shown in streamer mode.