Add command to automatically reload your theme #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
requested changes
Jul 22, 2023
There was a problem hiding this comment.
Should be toggleable as a command rather than a UI thing imo, since it's an extremely small amount of people it's relevant for
Instead of using a FileWatcher, I would prefer the simplicity of a QTimer that runs every X ms (maybe every 500ms?) and reloads the current theme - while less performant, I think it's simpler to reason about
pajlada
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an option to watch the custom theme and reload it on changes. The option is only active for the current session (until Chatterino is restarted) to reduce load.
This PR does a few more things. I wasn't sure if I should include this here. I could split the commits up until 8f4770a into a separate PR.