Define Git and date constants in executables only #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
requested changes
Jun 17, 2023
|
Each executable has to also link to the VERSION_PROJECT. objects don't have a link step so it can't be included in sub-dependencies |
pajlada
approved these changes
Jun 17, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the definitions
CHATTERINO_{GIT_{HASH, RELEASE, COMMIT, MODIFIED}, CMAKE_GEN_DATE}into the executable only. This removes them from thechatterino-libtarget, which in turn makes it possible to cache, since the definitions will be the same across many runs (mentioned in #4680 (comment)).Local compile times will also be improved (e.g. when recompiling on a new day).
To test this, you should rerun the Windows CI after this day (to get a new generator date) and check the Post Setup sccache (Windows) step for the amount of cache-hits.