Improve editing of hotkeys #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- argument descriptions now use "Something:" format if there are possibleArguments - Change UI texts for some actions
pajlada
requested changes
May 27, 2023
pajlada
approved these changes
May 27, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -66,6 +47,96 @@ EditHotkeyDialog::EditHotkeyDialog(const std::shared_ptr<Hotkey> hotkey, | |||
| this->ui_->argumentsEdit->setPlainText(""); | |||
| } | |||
| } | |||
| void EditHotkeyDialog::setFromHotkey(std::shared_ptr<Hotkey> hotkey) | |||
There was a problem hiding this comment.
warning: the parameter 'hotkey' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| void EditHotkeyDialog::setFromHotkey(std::shared_ptr<Hotkey> hotkey) | |
| void EditHotkeyDialog::setFromHotkey(const std::shared_ptr<Hotkey>& hotkey) |
src/widgets/dialogs/EditHotkeyDialog.hpp:51:
- void setFromHotkey(std::shared_ptr<Hotkey> hotkey);
+ void setFromHotkey(const std::shared_ptr<Hotkey>& hotkey);
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The UI will now show a simple picker on what a hotkey can do when there is such an option available.
For example
HotkeyCategory::Split -> "focus"action has only 4 directions available, so it's possible to add this. HoweverHotkeyCategory::Window -> "openTab"can have a number, so this approach does not extend to it.Here is how the new UI looks for actions that support it:
For actions that don't support it, nothing will change.