Fix: check reply-parent-user-id for blocked user

[2547techno]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Closes #4481 assuming option 2. from #4481 (comment) .

Reply context message is censored if from blocked user

[kornes]

we shouldn't hide messages from non blocked users,
personally i would go with censoring of reply context and replace it with some generic "Blocked message"

[2547techno]

we shouldn't hide messages from non blocked users, personally i would go with censoring of reply context and replace it with some generic "Blocked message"

Make's sense, it now replaces the message content with *blocked message*.

Another option may be to treat the message as if the "show reply context" setting was disabled which probably follows closer to what blocking a user achieves normally. This made more sense after hearing: https://www.twitch.tv/videos/1782533448?t=01h10m21s

I'll leave the PR as draft for now.

[kornes]

I think leaving reply context visible is better solution, because it let user know given message responds to blocked account and can be ignored right away.
Question if username should be also removed from context, i would leave it but not sure if everyone would agree with that, so maybe axe it too?

[2547techno]

Reply context looks like this now.

Any other thoughts are welcome. Marking ready for review :)

[Felanbird]

I'm putting in my vote for [Blocked user] instead of *Blocked user*

[2547techno]

Don't think anyone would object

[Felanbird]

Seems to work as expected, also tested replying to a block user just to make sure nothing crazy would happen, and that worked as expected as well.

[pajlada]

Only a nitpick on the changelog entry, implementation looks good to me 👍

[Felanbird]

LGTM - only issue I would have would be making sure our native show-blocked-messages-if-you're-a-mod works, but I have a vague memory of testing that myself.

[Felanbird]

@2547techno Thanks for your contribution! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the application.

To do so, open a new PR where you modify the contributors.txt file and add yourself to the list. Make sure to read the comments at a top for instructions.