Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize list of blocked users on IgnoresPage construction #4437

Merged
merged 9 commits into from
Mar 26, 2023

Conversation

Muzuwi
Copy link
Contributor

@Muzuwi Muzuwi commented Mar 6, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Due to lazyloading, the SettingsPage::onShow handler that sets up the block list is only called when the application settings dialog has already been shown once before. This caused the blocked user list to appear empty until the second time it was opened.

Correct this by explicitly regenerating the block list in the constructor of IgnoresPage.

Relevant commit, this issue was probably present since these changes: 70e5bd1b

Reproducing the issue

  1. Launch Chatterino (new instance), be logged in with a Twitch account that has blocked some users already
  2. Open Settings > Ignores > Users. The blocked user list is empty.
  3. Close the Settings dialog, and re-open Ignores > Users tab. The blocked user list is now populated properly.

The `SettingsPage::onShow` handler that sets up the block
list is only called when the application settings dialog
has already been shown once before. This caused the blocked
user list to appear empty until the second time it was opened.

Correct this by explicitly regenerating the block list in the
constructor of `IgnoresPage`.
@Muzuwi Muzuwi force-pushed the fix-blocked-users-lazy-loading branch from 9dd8c66 to f31e48c Compare March 10, 2023 19:31
@pajlada pajlada enabled auto-merge (squash) March 26, 2023 10:29
CHANGELOG.md Outdated Show resolved Hide resolved
@pajlada pajlada merged commit 1fbbef3 into Chatterino:master Mar 26, 2023
@Muzuwi Muzuwi deleted the fix-blocked-users-lazy-loading branch March 26, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants