Initialize list of blocked users on IgnoresPage construction #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SettingsPage::onShow` handler that sets up the block list is only called when the application settings dialog has already been shown once before. This caused the blocked user list to appear empty until the second time it was opened. Correct this by explicitly regenerating the block list in the constructor of `IgnoresPage`.
Muzuwi
force-pushed
the
fix-blocked-users-lazy-loading
branch
from
9dd8c66
to
f31e48c
Compare
pajlada
approved these changes
Mar 26, 2023
Muzuwi
commented
Mar 26, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Due to lazyloading, the
SettingsPage::onShowhandler that sets up the block list is only called when the application settings dialog has already been shown once before. This caused the blocked user list to appear empty until the second time it was opened.Correct this by explicitly regenerating the block list in the constructor of
IgnoresPage.Relevant commit, this issue was probably present since these changes: 70e5bd1b
Reproducing the issue