Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Handling of FFZ CDN URLs with https already appended #4432

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Fix Handling of FFZ CDN URLs with https already appended #4432

merged 2 commits into from
Mar 5, 2023

Conversation

dnsge
Copy link
Contributor

@dnsge dnsge commented Mar 5, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes #4430

Felanbird
Felanbird approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throwing in mm2pl's tired review
image

@Felanbird Felanbird enabled auto-merge (squash) March 5, 2023 00:18
Felanbird
Felanbird approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also my review that it works 👍
image

@Felanbird Felanbird merged commit b9e87dc into Chatterino:master Mar 5, 2023
github-actions[bot]
github-actions bot reviewed Mar 5, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/ffz/FfzUtil.cpp Show resolved Hide resolved
src/providers/ffz/FfzUtil.cpp Show resolved Hide resolved
This was referenced Mar 5, 2023
Closed
Merged
@dnsge dnsge deleted the fix/ffz-cdn-url-fix branch March 5, 2023 00:55
@Felanbird Felanbird mentioned this pull request Mar 5, 2023
Closed
Felanbird added a commit to Felanbird/chatterino2 that referenced this pull request Mar 12, 2023
@Felanbird
Fix Handling of FFZ CDN URLs with https already appended (Chatterino#…
5c3a34e 
…4432)
Felanbird added a commit to Felanbird/chatterino2 that referenced this pull request Mar 14, 2023
@Felanbird
Fix Handling of FFZ CDN URLs with https already appended (Chatterino#…
0d13cc2 
…4432)
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Felanbird Felanbird Felanbird approved these changes

@zneix zneix zneix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FFZ emotes no longer work
3 participants
@dnsge @Felanbird @zneix