Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all warnings from the cppcoreguidelines-pro-type-member-init clang-tidy check #4426

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Fix all warnings from the cppcoreguidelines-pro-type-member-init clang-tidy check #4426

merged 3 commits into from
Sep 9, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 4, 2023

  • Fix all warnings from the cppcoreguidelines-pro-type-member-init clang-tidy check
  • Update .gitignore

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@pajlada pajlada requested a review from Mm2PL March 4, 2023 12:01
pajlada
pajlada commented Mar 4, 2023
View reviewed changes
Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me, going to build & use it for a bit :-)

@pajlada pajlada force-pushed the fix/cppcoreguidelines-pro-type-member-init branch from 1bc8961 to a841a4b Compare May 8, 2023 15:34
@pajlada pajlada added this to the Post 2.4.4 milestone May 8, 2023
@pajlada pajlada modified the milestones: Post 2.4.4, Post 2.4.5 Aug 20, 2023
@pajlada
Copy link
Member Author

pajlada commented Sep 9, 2023

image

@pajlada pajlada force-pushed the fix/cppcoreguidelines-pro-type-member-init branch from a841a4b to 01a0b91 Compare September 9, 2023 10:25
@pajlada pajlada enabled auto-merge (squash) September 9, 2023 10:26
@pajlada pajlada merged commit d4558b5 into master Sep 9, 2023
16 checks passed
@pajlada pajlada deleted the fix/cppcoreguidelines-pro-type-member-init branch September 9, 2023 11:11
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mm2PL Mm2PL Awaiting requested review from Mm2PL

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
Post 2.4.5
Development

Successfully merging this pull request may close these issues.
1 participant
@pajlada