Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qt6 building #4393

Merged
merged 26 commits into from
Feb 19, 2023
Merged

Fix Qt6 building #4393

merged 26 commits into from
Feb 19, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Feb 19, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Add Qt Core5Compat dependency if building with Qt6
  • Add specialization to localizeNumber that accepts a qsizetype
  • Add missing QFile include to SoundController.cpp
  • Add missing QFile include to SettingsDialog.cpp
  • Add missing QFile include to AboutPage.cpp
  • Format IRC username-randomizer in IrcServer using QString arg
  • Comment out usage of setCodec in LinkParser.cpp for Qt6
  • Comment out usage of setCodec in AboutPage.cpp for Qt6
  • Store max spaces as a qsizetype in CommandController
  • Use QStringView.split instead of QString splitRef
  • intify some usages of size
  • Replace QStringRef with QStringView in TwitchMessageBuilder
  • Replace QStringRef with QStringView in ResizingTextEdit
  • Clarify QPoint constructor in SplitInput.cpp
  • Use initFrom instead of init in QStyleOption
  • Call result on QConcurrent runs in ModerationPage
  • Add github workflow for building on Qt6

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/util/Helpers.cpp Show resolved Hide resolved
src/util/Helpers.cpp Show resolved Hide resolved
src/widgets/Notebook.cpp Show resolved Hide resolved
src/widgets/Notebook.cpp Show resolved Hide resolved
@Nerixyz
Copy link
Contributor

Nerixyz commented Feb 19, 2023

This PR should also remove the following line:

# include <QtWidgets/QAction>

This header moved to QtGui but it's included above either way:

# include <QAction>

So it can be removed. CI doesn't catch this, since the Qt 6 runner has PCH disabled.

@pajlada pajlada changed the title Make changes to ensure project builds with Qt6 Fix Qt6 building Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants