-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Qt6 building #4393
Fix Qt6 building #4393
Conversation
error: conversion from 'int' to 'QChar' is ambiguous
This makes it work natively with std::max(maxSpaces, QString().size())
Since it keeps empty entries by default, this code is equivalent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
This PR should also remove the following line: chatterino2/src/PrecompiledHeader.hpp Line 108 in d3499e8
This header moved to chatterino2/src/PrecompiledHeader.hpp Line 16 in d3499e8
So it can be removed. CI doesn't catch this, since the Qt 6 runner has PCH disabled. |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
localizeNumber
that accepts aqsizetype
QFile
include toSoundController.cpp
QFile
include toSettingsDialog.cpp
QFile
include toAboutPage.cpp
setCodec
inLinkParser.cpp
for Qt6setCodec
inAboutPage.cpp
for Qt6qsizetype
inCommandController
int
ify some usages ofsize
QStringRef
withQStringView
in ResizingTextEditinitFrom
instead ofinit
in QStyleOptionresult
on QConcurrent runs in ModerationPage