Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete all but the last 5 crash dumps on startup #4392

Merged
merged 6 commits into from
Feb 19, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Feb 19, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

As mentioned in #4391, this ensures only the five most recent crashdumps are saved. This uses a similar strategy to how the cache is cleaned up after starting Chatterino.

Fixes #4391.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/RunGui.cpp Show resolved Hide resolved
@pajlada pajlada changed the title Only store the five most recent dumps Delete all but the last 5 crash dumps on startup Feb 19, 2023
@pajlada pajlada enabled auto-merge (squash) February 19, 2023 22:02
@pajlada pajlada merged commit c74b14a into Chatterino:master Feb 19, 2023
@Nerixyz Nerixyz deleted the fix/delete-crashes branch February 20, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure we don't store infinite crash dumps
2 participants