Disable ImageExpirationPool during testing #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
When running tests on macOS, the program finishes with the following error:
libc++abi: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argumentThis is caused by
ImageExpirationPoolwhich is indirectly being used in theEmojis.ShortcodeParsingtest. When the emoji Image objects are destructed, they are removed from the ImageExpirationPool. Despite having a static lifetime, theImageExpirationPoolseems to have been destroyed before theseImageobjects, so theImageExpirationPool's mutex is used after it has been destructed.The simple solution is to just disable the
ImageExpirationPoollogic during tests.