feat: Warn for commands with duplicate triggers

src/widgets/settingspages/CommandPage.cpp

@@ -11,6 +11,7 @@
 #include "util/StandardItemHelper.hpp"
 #include "widgets/helper/EditableModelView.hpp"
 
+#include <QColor>
 #include <QHeaderView>
 #include <QLabel>
 #include <QPushButton>
@@ -50,6 +51,23 @@ CommandPage::CommandPage()
             Command{"/command", "I made a new command HeyGuys"});
     });
 
+    QItemSelectionModel *selectionModel =
+        view->getTableView()->selectionModel();
+    QObject::connect(
+        selectionModel, &QItemSelectionModel::currentChanged, this,
+        [this, view](const QModelIndex &current, const QModelIndex &previous) {
+            if (this->handleCommandDuplicates(view))
+            {
+                this->duplicateCommandWarning->show();
+            }
+            else
+            {
+                this->duplicateCommandWarning->hide();
+            }
+        });
+
+    bool duplicatesExist = this->handleCommandDuplicates(view);
+
     // TODO: asyncronously check path
     if (QFile(c1settingsPath()).exists())
     {
@@ -81,8 +99,61 @@ CommandPage::CommandPage()
     text->setStyleSheet("color: #bbb");
     text->setOpenExternalLinks(true);
 
+    this->duplicateCommandWarning =
+        layout.emplace<QLabel>("Duplicate command names / triggers detected")
+            .getElement();
+    this->duplicateCommandWarning->setStyleSheet("color: yellow");
+    if (duplicatesExist)
+    {
+        this->duplicateCommandWarning->show();
+    }
+    else
+    {
+        this->duplicateCommandWarning->hide();
+    }
+
     // ---- end of layout
     this->commandsEditTimer_.setSingleShot(true);
 }
 
+bool CommandPage::handleCommandDuplicates(EditableModelView *view)
+{
+    bool retval = false;
+    QMap<QString, QList<int>> map = *new QMap<QString, QList<int>>();
+    for (int i = 0; i < view->getModel()->rowCount(); i++)
+    {
+        QString commandName = view->getModel()->index(i, 0).data().toString();
+        if (map.contains(commandName))
+        {
+            QList<int> value = map[commandName];
+            value.append(i);
+            map.insert(commandName, value);
+        }
+        else
+        {
+            map.insert(commandName, {i});
+        }
+    }
+
+    foreach (const QString &key, map.keys())
+    {
+        if (map[key].length() != 1)
+        {
+            retval = true;
+            foreach (int value, map[key])
+            {
+                view->getModel()->setData(view->getModel()->index(value, 0),
+                                          QColor("yellow"), Qt::ForegroundRole);
+            }
+        }
+        else
+        {
+            view->getModel()->setData(view->getModel()->index(map[key][0], 0),
+                                      QColor("white"), Qt::ForegroundRole);
+        }
+    }
+
+    return retval;
+}
+
 }  // namespace chatterino

src/widgets/settingspages/CommandPage.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include "widgets/helper/EditableModelView.hpp"
 #include "widgets/settingspages/SettingsPage.hpp"
 
 #include <QTextEdit>
@@ -11,9 +12,11 @@ class CommandPage : public SettingsPage
 {
 public:
     CommandPage();
+    bool handleCommandDuplicates(EditableModelView *view);
 
 private:
     QTimer commandsEditTimer_;
+    QLabel *duplicateCommandWarning;
 };
 
 }  // namespace chatterino