feat: Warn for commands with duplicate triggers

src/widgets/settingspages/CommandPage.cpp

@@ -11,6 +11,7 @@
 #include "util/StandardItemHelper.hpp"
 #include "widgets/helper/EditableModelView.hpp"
 
+#include <QColor>
 #include <QHeaderView>
 #include <QLabel>
 #include <QPushButton>
@@ -38,18 +39,35 @@ CommandPage::CommandPage()
     LayoutCreator<CommandPage> layoutCreator(this);
     auto layout = layoutCreator.setLayoutType<QVBoxLayout>();
 
-    EditableModelView *view =
+    this->view =
         layout.emplace<EditableModelView>(app->commands->createModel(nullptr))
             .getElement();
 
-    view->setTitles({"Trigger", "Command", "Show In\nMessage Menu"});
-    view->getTableView()->horizontalHeader()->setSectionResizeMode(
+    this->view->setTitles({"Trigger", "Command", "Show In\nMessage Menu"});
+    this->view->getTableView()->horizontalHeader()->setSectionResizeMode(
         1, QHeaderView::Stretch);
-    view->addButtonPressed.connect([] {
+    this->view->addButtonPressed.connect([] {
         getApp()->commands->items.append(
             Command{"/command", "I made a new command HeyGuys"});
     });
 
+    QItemSelectionModel *selectionModel =
+        this->view->getTableView()->selectionModel();
+    QObject::connect(
+        selectionModel, &QItemSelectionModel::currentChanged, this,
+        [this](const QModelIndex &current, const QModelIndex &previous) {
+            if (this->checkCommandDuplicates())
+            {
+                this->duplicateCommandWarning->show();
+            }
+            else
+            {
+                this->duplicateCommandWarning->hide();
+            }
+        });
+
+    bool duplicatesExist = this->checkCommandDuplicates();
+
     // TODO: asyncronously check path
     if (QFile(c1settingsPath()).exists())
     {
@@ -81,8 +99,64 @@ CommandPage::CommandPage()
     text->setStyleSheet("color: #bbb");
     text->setOpenExternalLinks(true);
 
+    this->duplicateCommandWarning =
+        layout.emplace<QLabel>("Duplicate command names / triggers detected")
+            .getElement();
+    this->duplicateCommandWarning->setStyleSheet("color: yellow");
+    if (duplicatesExist)
+    {
+        this->duplicateCommandWarning->show();
+    }
+    else
+    {
+        this->duplicateCommandWarning->hide();
+    }
+
     // ---- end of layout
     this->commandsEditTimer_.setSingleShot(true);
 }
 
+bool CommandPage::checkCommandDuplicates()
+{
+    bool retval = false;
+    QMap<QString, QList<int>> map = QMap<QString, QList<int>>();
+    for (int i = 0; i < this->view->getModel()->rowCount(); i++)
+    {
+        QString commandName =
+            this->view->getModel()->index(i, 0).data().toString();
+        if (map.contains(commandName))
+        {
+            QList<int> value = map[commandName];
+            value.append(i);
+            map.insert(commandName, value);
+        }
+        else
+        {
+            map.insert(commandName, {i});
+        }
+    }
+
+    foreach (const QString &key, map.keys())
+    {
+        if (map[key].length() != 1)
+        {
+            retval = true;
+            foreach (int value, map[key])
+            {
+                this->view->getModel()->setData(
+                    this->view->getModel()->index(value, 0), QColor("yellow"),
+                    Qt::ForegroundRole);
+            }
+        }
+        else
+        {
+            this->view->getModel()->setData(
+                this->view->getModel()->index(map[key][0], 0), QColor("white"),
+                Qt::ForegroundRole);
+        }
+    }
+
+    return retval;
+}
+
 }  // namespace chatterino

src/widgets/settingspages/CommandPage.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include "widgets/helper/EditableModelView.hpp"
 #include "widgets/settingspages/SettingsPage.hpp"
 
 #include <QTextEdit>
@@ -14,6 +15,10 @@ class CommandPage : public SettingsPage
 
 private:
     QTimer commandsEditTimer_;
+    QLabel *duplicateCommandWarning;
+    EditableModelView *view;
+
+    bool checkCommandDuplicates();
 };
 
 }  // namespace chatterino