Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up TwitchAccount emote stuff #4243

Merged
merged 8 commits into from
Dec 18, 2022
Merged

Clean up TwitchAccount emote stuff #4243

merged 8 commits into from
Dec 18, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Dec 18, 2022 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Remove unused TwitchAccount FollowResult enum
  • Remove unused TwitchEmoteSetResolverResponse struct
  • Remove unused and unimplemented getEmoteSetBatches function definition
  • Remove unused loadEmoteSetData and staticEmoteSets from TwitchAccount
  • Remove forward declaration of TwitchAccount in TwitchAccountManager
  • Split IgnorePhrase.hpp into a source/header file combo

@pajlada pajlada enabled auto-merge (squash) December 18, 2022 13:47
github-actions[bot]
github-actions bot reviewed Dec 18, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/ignores/IgnorePhrase.cpp Show resolved Hide resolved
src/controllers/ignores/IgnorePhrase.cpp Show resolved Hide resolved
src/controllers/ignores/IgnorePhrase.cpp Show resolved Hide resolved
src/providers/twitch/PubSubManager.cpp Show resolved Hide resolved
src/providers/twitch/PubSubManager.cpp Show resolved Hide resolved
@pajlada pajlada merged commit a715b1f into master Dec 18, 2022
@pajlada pajlada deleted the chore/refactor-and-clean-up-twitch-account-emote-stuff branch December 18, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pajlada