Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Usercard Popup not floating on tiling WMs on Linux #3511

Merged
merged 14 commits into from
Sep 16, 2023

Conversation

qooq69
Copy link
Contributor

@qooq69 qooq69 commented Jan 15, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes an issue on i3wm where the Usercard Popup is not floating when Automatically close usercard popup when it loses focus setting is enabled.
Tested on i3wm where it fixes the issue, and on KDE with seemingly no change in behavior.
Probably needs testing on other tiling Linux WMs.

@qooq69 qooq69 changed the title Fix Usercard Popup not floating Fixed Usercard Popup not floating on tiling WMs on Linux Feb 12, 2022
@pajlada pajlada added this to the Post 2.4.4 milestone May 8, 2023
@pajlada
Copy link
Member

pajlada commented May 8, 2023

Works as expected for me on i3 - I never noticed this was an issue since I have for_window [class="chatterino"] floating enable configured.

If possible, I'd like you to test this on your i3 setup & on KDE before I have this merged in.
I will test this on sway to make sure it doesn't make the experience worse.

@pajlada pajlada added the Waiting for author PR bounced back to author label May 8, 2023
@pajlada pajlada modified the milestones: Post 2.4.4, Post 2.4.5 Aug 20, 2023
@pajlada
Copy link
Member

pajlada commented Sep 9, 2023

@qooq69 Are you able to test this again on your system?

Open for anyone else: Please try this PR on sway to see if it changes the usercard popup experience at all

@qooq69
Copy link
Contributor Author

qooq69 commented Sep 11, 2023

Sorry for late reply. Lately I have been busy with uni and real life. Hopefully I'll be able to find some time this weekend to test it on both i3 and sway.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/DraggablePopup.cpp Show resolved Hide resolved
src/widgets/DraggablePopup.cpp Show resolved Hide resolved
@qooq69
Copy link
Contributor Author

qooq69 commented Sep 16, 2023

Okay, I have tested it on both i3 and sway. It appears to work without any problems on my machine.

Also, I'm unable to test it on KDE since I no longer use it, so someone else will have to test it there.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's assume it works as expected then!

@pajlada pajlada removed the Waiting for author PR bounced back to author label Sep 16, 2023
@pajlada pajlada merged commit 38c994b into Chatterino:master Sep 16, 2023
17 checks passed
@Felanbird
Copy link
Collaborator

I was on this PR and didn't notice anything unexpected, but I also don't open that many usercards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants