-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Usercard Popup not floating on tiling WMs on Linux #3511
Conversation
Works as expected for me on i3 - I never noticed this was an issue since I have If possible, I'd like you to test this on your i3 setup & on KDE before I have this merged in. |
@qooq69 Are you able to test this again on your system? Open for anyone else: Please try this PR on sway to see if it changes the usercard popup experience at all |
Sorry for late reply. Lately I have been busy with uni and real life. Hopefully I'll be able to find some time this weekend to test it on both i3 and sway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Okay, I have tested it on both i3 and sway. It appears to work without any problems on my machine. Also, I'm unable to test it on KDE since I no longer use it, so someone else will have to test it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's assume it works as expected then!
I was on this PR and didn't notice anything unexpected, but I also don't open that many usercards. |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Fixes an issue on i3wm where the Usercard Popup is not floating when
Automatically close usercard popup when it loses focus
setting is enabled.Tested on i3wm where it fixes the issue, and on KDE with seemingly no change in behavior.
Probably needs testing on other tiling Linux WMs.