Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let framework be used from app extensions #694

Closed
wants to merge 5 commits into from
Closed

Let framework be used from app extensions #694

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 21, 2016

Fixes issue: #693

@ghost ghost changed the title App extensions Let framework be used from app extensions Jan 21, 2016
@pmairoldi
Copy link
Collaborator

From what I can gather this just adds APPLICATION_EXTENSION_API_ONLY to the project file. Could you rebase and add only that change?

@ghost
Copy link
Author

ghost commented Jan 22, 2016

I understand, that's fine. But do you mean rebasing just the 2 work commits or also the merges?

@pmairoldi
Copy link
Collaborator

I would like it if this pull request included only the flag changes. There seems to be some logic change in the first commit. I was asking you to rebase because I wasn't sure if those came from master.

@pmairoldi
Copy link
Collaborator

If the logic change is not from master and you believe it is a bug. Just make a separate pull request 👍

@ghost
Copy link
Author

ghost commented Jan 22, 2016

No no, the logic change comes from master. Anyway I think the best will be create a new one with only the flag changes. Thanks!

@pmairoldi
Copy link
Collaborator

Thanks. That would be great.

@danielgindi
Copy link
Collaborator

Just a head-up: I am planning on a release very soon. This is a small change that can be easily integrated without delaying anything, so if you want it to go in the next release please hurry :-)

@ghost
Copy link
Author

ghost commented Jan 25, 2016

Thanks for the heads-up @danielgindi. I'm closing this PR and opening another one with just that change.

@ghost ghost closed this Jan 25, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants