-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let framework be used from app extensions #694
Conversation
Make getBarBounds callable from Objective-C code (Fixes #570)
…ide an app extension.
…ide an app extension for TV framework too.
Conflicts: Charts/Charts.xcodeproj/project.pbxproj
From what I can gather this just adds |
I understand, that's fine. But do you mean rebasing just the 2 work commits or also the merges? |
I would like it if this pull request included only the flag changes. There seems to be some logic change in the first commit. I was asking you to rebase because I wasn't sure if those came from master. |
If the logic change is not from master and you believe it is a bug. Just make a separate pull request 👍 |
No no, the logic change comes from master. Anyway I think the best will be create a new one with only the flag changes. Thanks! |
Thanks. That would be great. |
Just a head-up: I am planning on a release very soon. This is a small change that can be easily integrated without delaying anything, so if you want it to go in the next release please hurry :-) |
Thanks for the heads-up @danielgindi. I'm closing this PR and opening another one with just that change. |
Fixes issue: #693