Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min version to 13 for ios project #5062

Merged

Conversation

waterskier2007
Copy link

Issue Link πŸ”—

Attempts to fix testing issues here #5028

Goals ⚽

Fix testing issues for release 5.0.0

Implementation Details 🚧

Just bumps the iOS demo project min version to 13 (and tvOS)

Testing Details πŸ”

This should fix tests as reported here #5028 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, not sure if this was intended, but there is no need to bump the frameworks minimum deployment target to 13

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@waterskier2007
Copy link
Author

@pmairoldi or @danielgindi thoughts on getting this merged in to try and resolve the test issues on the release branch?

@pmairoldi
Copy link
Collaborator

Thank you! Sorry I've been pretty busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants