Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of special character in folder name don't allow unzip correct… #4661

Merged

Conversation

rquesada
Copy link

Issue Link 🔗

#4660
Screen Shot 2021-06-11 at 10 52 03 AM

Goals ⚽

Make it possible for users to unzip the library with a script or unzip command like:
unzip -d DestinationFile Charts-4.0.1.zip

Implementation Details 🚧

Rename the folder, change the icon  for Apple.

Create the same change in Utilities.swift

let snapshotDirectory = fileUrl.deletingLastPathComponent()
        .appendingPathComponent("__Snapshots__AppleSilicon__")
        .appendingPathComponent(fileName)
        .path

Testing Details 🔍

Download the zip:
https://github.com/rquesada/Charts/archive/refs/heads/fix/4660-remove-special-character.zip

and run the following command in your terminal:
unzip -d DestinationFile Charts-fix-4660-remove-special-character.zip

@pmairoldi pmairoldi merged commit 2037006 into ChartsOrg:master Sep 13, 2022
@pmairoldi
Copy link
Collaborator

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants