Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform separation #4178

Merged
merged 6 commits into from
Nov 8, 2019
Merged

Platform separation #4178

merged 6 commits into from
Nov 8, 2019

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Oct 15, 2019

There are no code changes here. I only split out the different pieces of platform to make it more easily maintainable.

Must be merged after #4175

@jjatie jjatie requested a review from liuxuan30 October 15, 2019 15:37
@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #4178 into master will not change coverage.
The diff coverage is 22.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4178   +/-   ##
=======================================
  Coverage   41.48%   41.48%           
=======================================
  Files         119      123    +4     
  Lines       14042    14042           
=======================================
  Hits         5826     5826           
  Misses       8216     8216
Impacted Files Coverage Δ
Source/Charts/Charts/ChartViewBase.swift 30.22% <ø> (ø) ⬆️
Source/Charts/Utils/Platform.swift 0% <ø> (-19.12%) ⬇️
Source/Charts/Utils/Platform+Touch Handling.swift 0% <0%> (ø)
Source/Charts/Utils/Platform+Gestures.swift 11.11% <11.11%> (ø)
Source/Charts/Utils/Platform+Graphics.swift 37.5% <37.5%> (ø)
...Charts/Data/Implementations/ChartBaseDataSet.swift 25.82% <50%> (ø) ⬆️
Source/Charts/Utils/Platform+Color.swift 62.5% <62.5%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5fda8f...4892409. Read the comment docs.

@liuxuan30 liuxuan30 merged commit b630e88 into master Nov 8, 2019
water-su added a commit to water-su/Charts that referenced this pull request Feb 7, 2020
* origin/master: (256 commits)
  Add our first super sponsor!
  Updated test screenshots
  Add option to draw grid lines in front of data
  Removed double spacing for labelRotatedHeight
  Fixes an issue with string comparison in ChartData for finding a dataset by its label (Fixes ChartsOrg#4274)
  Simplify code
  Use faster check for line whether it's inside drawing rect
  Corrected pie `isHighlightEnabled` - render normally when disabled
  Restored correct velocity sampler
  Deduplicate BalloonMarker code
  Unified styling
  Call chartViewDidEndPanning on when *panning* is ended
  Propagate file header to newer files
  Removed redundant minEntries > 0
  labelXOffset = 10 is default for radar chart only
  Update README.md, added link to tutorial about Radar Charts.
  Changes to fix Catalyst compatibility
  Allowing overrides for YAxisRenderer.drawYLabels (ChartsOrg#4089)
  move isDrawCirclesEnabled check further up in code to avoid creating … (ChartsOrg#4050)
  Platform separation (ChartsOrg#4178)
  ...

# Conflicts:
#	Source/Charts/Components/AxisBase.swift
#	Source/Charts/Data/Implementations/Standard/LineRadarChartDataSet.swift
#	Source/Charts/Highlight/Highlight.swift
@jjatie jjatie deleted the platform-separation branch January 26, 2021 12:27
SwiftPolar pushed a commit to SwiftPolar/Charts that referenced this pull request Mar 20, 2023
* Added system dark mode support for primary label colors in the framework

Moved Color to its own Platform file

* Relocated color file

* Reverted demo change

* Separated `Platform` into multiple files for better organization

* Updated from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants