Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements in barRect height calculation #3650

Merged
merged 24 commits into from
Nov 1, 2018
Merged

improvements in barRect height calculation #3650

merged 24 commits into from
Nov 1, 2018

Commits on Sep 19, 2018

  1. fixed barRectCaculation

    @potato04
    potato04 committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    e2fa55b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2018

  1. fixed offset calculation

    @potato04
    potato04 committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    ed9d70d View commit details
    Browse the repository at this point in the history

  2. Fix the mess caused by the setting the min&min value of the y-axis by… 

    … error :

Just simply swap their values
    @potato04
    potato04 committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    6cbecb8 View commit details
    Browse the repository at this point in the history

  3. Fix the mess caused by the setting the min&min value of the y-axis by… 

    … error
    @potato04
    potato04 committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    526a73a View commit details
    Browse the repository at this point in the history

  4. Revert "Fix the mess caused by the setting the min&min value of the y… 

    …-axis by error"

This reverts commit 526a73a.
    @potato04
    potato04 committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    4548474 View commit details
    Browse the repository at this point in the history

  5. Fix the mess caused by the setting the min&min value of the y-axis by… 

    … error
    @potato04
    potato04 committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    59d6986 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. update offset calculation

    @potato04
    potato04 committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    c774d20 View commit details
    Browse the repository at this point in the history

  2. update code style

    @potato04
    potato04 committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    1b6cc38 View commit details
    Browse the repository at this point in the history

  3. update code style

    @potato04
    potato04 committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    daff645 View commit details
    Browse the repository at this point in the history

  4. update offset calculation

    @potato04
    potato04 committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    a77a358 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. keep barRect calculation untouched 

    try to simply the calculation. keep barRect calculation untouched
    @liuxuan30
    liuxuan30 authored Sep 29, 2018
    Configuration menu
    Copy the full SHA
    b67c251 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2018

  1. After the correction of min and max , they should be assigned back to… 

    … _axisMinimum and _axisMaximum
    @potato04
    potato04 committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    9a9edcb View commit details
    Browse the repository at this point in the history

  2. add demo for bar chart unit test

    @potato04
    potato04 committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    bf86f2c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2018

  1. update unit test

    @potato04
    potato04 committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    f69c6ee View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. revert last commit

    @potato04
    potato04 committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    ce578a0 View commit details
    Browse the repository at this point in the history

  2. update unit test

    @potato04
    potato04 committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    afac36e View commit details
    Browse the repository at this point in the history

  3. make sure max is greater than min & 

    turnoff record mode for barchartest
    @potato04
    potato04 committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    b57cd0b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. add new UT and fix some issues. 

    1. add more bar chart UT
2. code style fix
3. manually add chart.notifyDataSetChanged() - some old UT and new ones forget to call this method, leading the test images to be wrong.

Notice:
some test images diff shows slight pixel shift, not sure why, but both old and new image seems drawing correctly
    @liuxuan30
    liuxuan30 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    0e7ff42 View commit details
    Browse the repository at this point in the history

  2. update tvOS images

    @liuxuan30
    liuxuan30 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    104c0c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. update tolerance to 1% & more swift-y

    @liuxuan30
    liuxuan30 committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    e6098f3 View commit details
    Browse the repository at this point in the history

  2. update tvOS images, removing "Description Label", (not rendered anymore) 

    changing tolerance will trigger "Description Label" detection
    @liuxuan30
    liuxuan30 committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    76b1f6f View commit details
    Browse the repository at this point in the history

  3. update iOS test images, "Description Label" no longer rendered.

    @liuxuan30
    liuxuan30 committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    d5d9abd View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. fixed offset calculation in some cases. 

    moved those codes into the for loop. because the offset of each bar may be different.
(detail in comments)
    @potato04
    potato04 committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    8da5272 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Update Source/Charts/Renderers/BarChartRenderer.swift 

    Co-Authored-By: potato04 <[email protected]>
    @jjatie @potato04
    jjatie and potato04 authored Oct 22, 2018
    Configuration menu
    Copy the full SHA
    8ae48b9 View commit details
    Browse the repository at this point in the history