Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HB-6635] Per Partner Consent APIs #203

Merged
merged 6 commits into from
Nov 6, 2023
Merged

[HB-6635] Per Partner Consent APIs #203

merged 6 commits into from
Nov 6, 2023

Conversation

SCastanedaMunoz
Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz commented Nov 2, 2023 •
edited
Loading

Title

HB-6635 Per Partner Consent APIs

Description

Allows consent to be set on a partner specific basis. Partner identifiers can be found under Partners.cs. Partner consent can be set at any point during the application lifecycle.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SCastanedaMunoz SCastanedaMunoz requested review from a team, bwised and kushG and removed request for a team November 2, 2023 21:28
@SCastanedaMunoz SCastanedaMunoz self-assigned this Nov 2, 2023
@SCastanedaMunoz SCastanedaMunoz added the enhancement New feature or request label Nov 2, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Nov 2, 2023
cb-jpadilla
cb-jpadilla reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@cb-jpadilla cb-jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment. So far, good on Android. ✔️

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023 •
edited
Loading

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 269fef0. ± Comparison against base commit 2b3fc79.

♻️ This comment has been updated with latest results.

@SCastanedaMunoz SCastanedaMunoz marked this pull request as ready for review November 6, 2023 20:33
kushG
kushG approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@kushG kushG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

pleasesavemycat
pleasesavemycat approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@pleasesavemycat pleasesavemycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SCastanedaMunoz SCastanedaMunoz merged commit aff912d into develop Nov 6, 2023
3 checks passed
@SCastanedaMunoz SCastanedaMunoz deleted the HB-6635-mediation-unity-per-partner-consent-api branch November 6, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-jpadilla cb-jpadilla cb-jpadilla approved these changes

@pleasesavemycat pleasesavemycat pleasesavemycat approved these changes

@kushG kushG kushG approved these changes

@bwised bwised Awaiting requested review from bwised bwised was automatically assigned from ChartBoost/helium-unity

Assignees

@SCastanedaMunoz SCastanedaMunoz

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SCastanedaMunoz @kushG @pleasesavemycat @cb-jpadilla