Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Fix for ChartboostMediationBannerAdWrapper.h #198

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

kushG
Copy link
Contributor

@kushG kushG commented Oct 26, 2023

Title

Platform Fix for ChartboostMediationBannerAdWrapper.h

Description

ChartboostMediationBannerAdWrapper.h file was marked to be packaged for all the platforms. It is now updated to be packaged only on iOS platforms

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kushG kushG self-assigned this Oct 26, 2023
@kushG kushG added the bugfix Something has been fixed label Oct 26, 2023
@github-actions
Copy link

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 1098e86. ± Comparison against base commit 1fd6686.

@SCastanedaMunoz SCastanedaMunoz merged commit e80d8b3 into develop Oct 27, 2023
3 checks passed
@SCastanedaMunoz SCastanedaMunoz deleted the kg/platform-fix branch October 27, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants